Correct issue where pre-deploy scripts do not have root access #6791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script This removes the extra indirection in the deploy process for triggering the hooks.
…-release process We still re-add them in the builder-release phase to ensure users don't set incorrect ones in a custom trigger.
…r` plugin trigger This fixes an issue where the post-release-builder trigger inadvertently modifies the image. We take advantage of the fact that env vars are available at the `pre-release-builder` phase to ensure any image modifications occur as appropriate.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 7, 2024
# History ## 0.34.4 Install/update via the bootstrap script: ```shell wget -NP . https://dokku.com/install/v0.34.4/bootstrap.sh sudo DOKKU_TAG=v0.34.4 bash bootstrap.sh ``` ### Bug Fixes - #6801: @josegonzalez Guard against invalid proxy values due to move of port mapping to ports plugin - #6798: @josegonzalez Implement missing scheduler-app-status trigger in k3s scheduler plugin - #6791: @josegonzalez Correct issue where pre-deploy scripts do not have root access ### New Features - #6800: @josegonzalez Update message for deployment tasks that execute in ephemeral containers ### Documentation - #6799: @josegonzalez Document that a registry is required for k3s usage ### Tests - #6802: @josegonzalez Update test for new deployment task output ### Dependencies - #6807: @josegonzalez chore: bump go modules - #6805: @dependabot[bot] chore(deps): bump golang.org/x/sync from 0.6.0 to 0.7.0 in /plugins/common - #6806: @dependabot[bot] chore(deps): bump golang.org/x/crypto from 0.21.0 to 0.22.0 in /plugins/common - #6803: @dependabot[bot] chore(deps): bump golang.org/x/sync from 0.6.0 to 0.7.0 in /plugins/scheduler-docker-local - #6804: @dependabot[bot] chore(deps): bump golang.org/x/sync from 0.6.0 to 0.7.0 in /plugins/app-json - #6794: @dependabot[bot] chore(deps): bump golang from 1.22.1 to 1.22.2 in /tests/apps/zombies-dockerfile-tini - #6796: @dependabot[bot] chore(deps): bump golang from 1.22.1 to 1.22.2 in /tests/apps/gogrpc - #6793: @dependabot[bot] chore(deps): bump golang from 1.22.1 to 1.22.2 in /tests/apps/zombies-dockerfile-no-tini - #6797: @dependabot[bot] chore(deps): bump golang from 1.22.1 to 1.22.2 in /tests/apps/go-fail-postdeploy - #6795: @dependabot[bot] chore(deps): bump google.golang.org/grpc from 1.62.1 to 1.63.0 in /tests/apps/gogrpc - #6792: @dependabot[bot] chore(deps): bump golang from 1.22.1 to 1.22.2 in /tests/apps/go-fail-predeploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to refactors in herokuish 0.8/0.9 and Dokku 0.34.x, pre-deploy scripts could no longer interact with the filesystem as root, meaning they could not change things outside of
/app. This change ensures the previous behavior works again, while also ensuring files in root stay as expected.