这是indexloc提供的服务，不要输入任何密码
Skip to content

Add --global flag to ps:set #6779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Add --global flag to ps:set #6779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugins/ps/src/subcommands/subcommands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,16 @@ func main() {
err = ps.CommandScale(appName, *skipDeploy, processTuples)
case "set":
args := flag.NewFlagSet("ps:set", flag.ExitOnError)
global := args.Bool("global", false, "--global: set a global property")
args.Parse(os.Args[2:])
appName := args.Arg(0)
property := args.Arg(1)
value := args.Arg(2)
if *global {
appName = "--global"
property = args.Arg(0)
value = args.Arg(1)
}
err = ps.CommandSet(appName, property, value)
case "start":
args := flag.NewFlagSet("ps:start", flag.ExitOnError)
Expand Down
48 changes: 48 additions & 0 deletions tests/unit/ps-general-1.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,54 @@ teardown() {
assert_output_contains "$CID" 6
}

@test "(ps:set) procfile" {
run /bin/bash -c "dokku ps:set --global procfile-path .dokku/Procfile"
echo "output: $output"
echo "status: $status"
assert_success

run /bin/bash -c "dokku ps:report $TEST_APP --ps-computed-procfile-path"
echo "output: $output"
echo "status: $status"
assert_output ".dokku/Procfile"
assert_success

run /bin/bash -c "dokku ps:report $TEST_APP --ps-global-procfile-path"
echo "output: $output"
echo "status: $status"
assert_output ".dokku/Procfile"
assert_success

run /bin/bash -c "dokku ps:report $TEST_APP --ps-procfile-path"
echo "output: $output"
echo "status: $status"
assert_output ""
assert_success

run /bin/bash -c "dokku ps:set --global procfile-path"
echo "output: $output"
echo "status: $status"
assert_success

run /bin/bash -c "dokku ps:report $TEST_APP --ps-computed-procfile-path"
echo "output: $output"
echo "status: $status"
assert_output "Procfile"
assert_success

run /bin/bash -c "dokku ps:report $TEST_APP --ps-global-procfile-path"
echo "output: $output"
echo "status: $status"
assert_output "Procfile"
assert_success

run /bin/bash -c "dokku ps:report $TEST_APP --ps-procfile-path"
echo "output: $output"
echo "status: $status"
assert_output ""
assert_success
}

@test "(ps:scale) procfile commands extraction" {
source "$PLUGIN_CORE_AVAILABLE_PATH/ps/functions"
cat <<EOF >"$DOKKU_LIB_ROOT/data/ps/$TEST_APP/Procfile"
Expand Down