这是indexloc提供的服务，不要输入任何密码
Skip to content

Ensure files get created with the correct permissions when building with herokuish #6775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2024
Merged

Ensure files get created with the correct permissions when building with herokuish #6775

merged 2 commits into from
Mar 29, 2024

Conversation

@josegonzalez
Copy link
Member

@josegonzalez josegonzalez commented Mar 28, 2024

This will allow us to skip more chown operations - and hopefully eventually drop them completely.

@josegonzalez
fix: ensure files get created with the correct permissions when build…
8265517 
…ing with herokuish

This will allow us to skip more chown operations - and hopefully eventually drop them completely.
@josegonzalez josegonzalez merged commit f4b1ce2 into master Mar 29, 2024
@josegonzalez josegonzalez deleted the better-herokuish-perms branch March 29, 2024 00:09
github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
Release 0.34.1
0a1f787 
# History

## 0.34.1

Install/update via the bootstrap script:

```shell
wget -NP . https://dokku.com/install/v0.34.1/bootstrap.sh
sudo DOKKU_TAG=v0.34.1 bash bootstrap.sh
```

### Bug Fixes

- #6775: @josegonzalez Ensure files get created with the correct permissions when building with herokuish
- #6739: @AndrewKvalheim Dereference annotated git tags when deploying via git:sync
- #6743: @testwill Fix typo in app-json output

### New Features

- #6768: @josegonzalez Migrate away from transitional packages

### Documentation

- #6763: @iloveitaly Add docker-compose example to installation docs
- #6757: @josegonzalez Add documentation issue template
- #6742: @josegonzalez Remove trailing whitespace from history doc

### Dependencies

- #6772: @dependabot[bot] chore(deps): bump tj-actions/changed-files from 43.0.1 to 44.0.0
- #6766: @dependabot[bot] chore(deps): bump mkdocs-material from 9.5.14 to 9.5.15 in /docs/_build
- #6744: @dependabot[bot] chore(deps): bump github.com/docker/docker from 24.0.7+incompatible to 24.0.9+incompatible in /plugins/scheduler-k3s
- #6754: @dependabot[bot] chore(deps): bump express from 4.18.3 to 4.19.1 in /tests/apps/dockerfile-app-json-formations
- #6745: @dependabot[bot] chore(deps): bump express from 4.18.3 to 4.19.1 in /tests/apps/nodejs-express
- #6746: @dependabot[bot] chore(deps): bump tj-actions/changed-files from 43.0.0 to 43.0.1
- #6747: @dependabot[bot] chore(deps): bump express from 4.18.3 to 4.19.1 in /tests/apps/.websocket.disabled
- #6748: @dependabot[bot] chore(deps): bump express from 4.18.3 to 4.19.1 in /tests/apps/nodejs-express-noprocfile
- #6749: @dependabot[bot] chore(deps): bump express from 4.18.3 to 4.19.1 in /tests/apps/nodejs-express-noappjson
- #6750: @dependabot[bot] chore(deps): bump express from 4.18.3 to 4.19.1 in /tests/apps/dockerfile-procfile-bad
- #6751: @dependabot[bot] chore(deps): bump importlib-metadata from 7.0.2 to 7.1.0 in /docs/_build
- #6752: @dependabot[bot] chore(deps): bump express from 4.18.3 to 4.19.1 in /tests/apps/dockerfile-procfile
- #6753: @dependabot[bot] chore(deps): bump express from 4.18.3 to 4.19.1 in /tests/apps/gitsubmodules
- #6741: @dependabot[bot] chore(deps): bump github.com/onsi/gomega from 1.31.1 to 1.32.0 in /plugins/common
- #6740: @dependabot[bot] chore(deps): bump github.com/onsi/gomega from 1.31.1 to 1.32.0 in /plugins/config
@constantgillet
Copy link

constantgillet commented Apr 1, 2024

Hey @josegonzalez.
I think that I have a problem with this update:

I am using dokku -v tells me that I am using dokku version 0.34.2

 -----> Deploying web (count=1)        
        Attempting pre-flight checks (web.1)        
 -----> Executing 2 healthchecks                                                                
        Running healthcheck name='default' type='uptime' uptime=10                              
        Running healthcheck name='port listening check' attempts=3 port=5000 retries=2 timeout=5 type='listening' wait=5        
        Healthcheck succeeded name='port listening check'                                       
  !     Failure in name='default': container has restarted 6 times                              
 =====> Start healthcheck output                                                                
        state=restarting                                                                        
 =====> End healthcheck output                                                                  
 45783d7c48a82f4f83f39166ce20392709d0731ecae1a2f7d53bc564e34d0570        
  !     Could not start due to 1 failed checks (web.1)        
 =====> Start of rendless container output (web.1)        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
 =====> End of rendless container output (web.1)        
 =====> Start of  container output (.)        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
        chown: changing ownership of '/app/.release': Operation not permitted        
        chown: changing ownership of '/app/Procfile': Operation not permitted        
        chown: changing ownership of '/app/.basher': Operation not permitted        
        chown: changing ownership of '/app/.basher/bash': Operation not permitted        
 =====> End of  container output (.)

@josegonzalez
Copy link
Member Author

josegonzalez commented Apr 1, 2024

Please ensure you're running a newer version of herokuish as well.

@constantgillet
Copy link

constantgillet commented Apr 1, 2024

Please ensure you're running a newer version of herokuish as well.

thanks for your answer

I am using the latest version of herokuish

remote: -----> Building rendless from gliderlabs/herokuish:latest

@josegonzalez
Copy link
Member Author

josegonzalez commented Apr 1, 2024 •
edited
Loading

Unfortunately "latest" isn't a particular version... I should probably somehow expand that in deploy output.

Check dokku report output and ensure you are running at least herokuish 0.9.0.

@josegonzalez
Copy link
Member Author

josegonzalez commented Apr 1, 2024

You can update via dokku-update run

@constantgillet
Copy link

constantgillet commented Apr 1, 2024

Unfortunately "latest" isn't a particular version... I should probably somehow expand that in deploy output.

Check dokku report output and ensure you are running at least herokuish 0.9.0.

I have updated herokuish to gliderlabs/herokuish:v0.9.0 and now it works fine...
Sorry for my mistake and thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merge-level: patch plugin: builders type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@josegonzalez @constantgillet