这是indexloc提供的服务，不要输入任何密码
Skip to content

Ensure we cleanup the data directory on app deletion #6705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Ensure we cleanup the data directory on app deletion #6705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions plugins/git/internal-functions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,12 @@ cmd-git-sync() {

verify_app_name "$APP"

if [[ -d "$DOKKU_LIB_ROOT/data/git/$APP" ]]; then
local APP_CLONE_ROOT="$DOKKU_LIB_ROOT/data/git/$APP"

if [[ -d "$APP_CLONE_ROOT" ]]; then
if has_tty eq 0; then
cmd-git-unlock "$APP"
if [[ -d "$DOKKU_LIB_ROOT/data/git/$APP" ]]; then
if [[ -d "$APP_CLONE_ROOT" ]]; then
dokku_log_fail "Failed to delete existing clone folder"
exit 15
fi
Expand Down Expand Up @@ -266,6 +268,7 @@ cmd-git-unlock() {
dokku_log_info1 "No clone folder exists app already unlocked"
fi
}

cmd-git-public-key() {
declare desc="outputs the dokku public deploy key"
local cmd="git:public-key"
Expand Down
2 changes: 2 additions & 0 deletions plugins/git/post-delete
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ trigger-git-post-delete() {
declare desc="destroys the git properties for a given app"
declare trigger="post-delete"
declare APP="$1"
local APP_CLONE_ROOT="$DOKKU_LIB_ROOT/data/git/$APP"

fn-plugin-property-destroy "git" "$APP"
rm -rf "$APP_CLONE_ROOT"
}

trigger-git-post-delete "$@"