Use copytruncate in logrotate commands #6703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While using create is more correct, logs in Dokku are considered ephemeral, and thus shouldn't be considered subject to the more comprehensive log retention standards one might require out of a logging system. By switching to copytruncate, we can ensure that logs mounted from within containers do not have that matched the old settings (closes #6633) and cases where the log file is written by a user other than the one specified in the old logrotate settings (closes #4000).
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
# History ## 0.34.0 Install/update via the bootstrap script: ```shell wget -NP . https://dokku.com/install/v0.34.0/bootstrap.sh sudo DOKKU_TAG=v0.34.0 bash bootstrap.sh ``` See the [0.34.0 migration guide](/docs/appendices/0.34.0-migration-guide.md) for more information on migrating to 0.34.0. ### Bug Fixes - #6724: @josegonzalez Correctly check if a repository has code or not in git plugin - #6721: @josegonzalez Correct issue where cron properties cannot be retrieved if global - #6720: @josegonzalez Add nginx-property binary to gitignore - #6708: @josegonzalez Correctly handle quoted spaces over ssh - #6707: @josegonzalez Correct issue where removing by index failed due to incorrect input validation - #6705: @josegonzalez Ensure we cleanup the data directory on app deletion - #6703: @josegonzalez Use copytruncate in logrotate commands ### New Features - #6725: @josegonzalez Warn when publish ports if scaling up or zero downtime is enabled - #6719: @josegonzalez Add a make target to copy the dokku binary over - #6717: @josegonzalez Add ability to only build synced repo if there are changes - #6715: @josegonzalez Add disk utilization to report output - #6704: @josegonzalez Switch the default k3s routing layer from traefik to nginx ### Removals - #6700: @josegonzalez Remove priority property from traefik plugin ### Refactors - #6714: @josegonzalez Use CallPlugnTrigger instead of PlugnTriggerSetup - #6713: @josegonzalez Use CallPlugnTrigger instead of PlugnTrigger - #6712: @josegonzalez Use CallPlugnTrigger instead of PlugnTriggerOutput - #6711: @josegonzalez Use CallPlugnTrigger instead of PlugnTriggerOutputAsString - #6681: @josegonzalez Migrate to single ingress per app/domain combination when using nginx for k3s proxying - #6156: @josegonzalez Migrate the app deploy lock to the data directory ### Documentation - #6738: @josegonzalez Update migration guide for 0.34.x - #6731: @strugee Clarify alternate proxy support status ### Dependencies - #6736: @dependabot[bot] chore(deps): bump mkdocs-material from 9.5.13 to 9.5.14 in /docs/_build - #6729: @dependabot[bot] chore(deps): update markdown requirement from <3.6,>=3.2.1 to >=3.2.1,<3.7 in /docs/_build - #6728: @dependabot[bot] chore(deps): bump zipp from 3.17.0 to 3.18.1 in /docs/_build - #6727: @dependabot[bot] chore(deps): bump tj-actions/changed-files from 42.1.0 to 43.0.0 - #6723: @dependabot[bot] chore(deps): bump zipp from 3.17.0 to 3.18.0 in /docs/_build - #6722: @dependabot[bot] chore(deps): bump tj-actions/changed-files from 42.1.0 to 43.0.0 - #6710: @dependabot[bot] chore(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 in /plugins/scheduler-k3s - #6709: @dependabot[bot] chore(deps): bump zipp from 3.17.0 to 3.18.0 in /docs/_build ### Other - #6718: @josegonzalez Write current process id to all acquired lock files - #6706: @josegonzalez Remove git:unlock command - #6650: @bastianh Do not expose all containers via traefik by default - #6632: @josegonzalez Simplify file ownership in the container by setting the process ownership during the build process - #6630: @josegonzalez Remove unused code for copying cache directories
Contributor
|
Is this switch intended to happen automatically or does it require manual migration? |
Member
Author
|
It happens on upgrade to the newer Dokku version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using create is more correct, logs in Dokku are considered ephemeral, and thus shouldn't be considered subject to the more comprehensive log retention standards one might require out of a logging system.
By switching to copytruncate, we can ensure that logs mounted from within containers do not have that matched the old settings and cases where the log file is written by a user other than the one specified in the old logrotate settings.
Closes #6633
Closes #4000