Deprecate proxy-configure-ports plugin trigger in favor of ports-configure #5997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralizing port-related code in the ports plugin will help in the removal of all the various port management options.
While this should ideally live in the ports plugin, this is the smallest lift we can do to expose the functionality
…ports-configure This also rewrites the logic to be in golang, which will make it easier to refactor portions of it to use the property system going forward.
This can be removed once we migrate to properties, but otherwise this breaks deploys as somehow it gets triggered in the process of fetching the docker run arguments...
This was referenced Jul 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also rewrites the logic to be in golang, which will make it easier to refactor portions of it to use the property system going forward.