-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Stop using the latest tag for the default DOKKU_CNB_BUILDER
#5862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previously the default value for `DOKKU_CNB_BUILDER` was `heroku/buildpacks`, which for Docker is equivalent to `heroku/buildpacks:latest`. The `latest` tag is about to be deleted (see heroku/cnb-builder-images#344), so this switches the default value to `heroku/buildpacks:20` - which is what the `latest` tag is currently as alias for. Longer term, `DOKKU_CNB_BUILDER` should be switched to the non-deprecated `heroku/builder:*` images, however, that's potentially a breaking change, so is out of scope of this bug-fix PR. For the list of available builders/tags, see: https://github.com/heroku/builder#heroku-builder-images Fixes dokku#5861.
latest tag for the default DOKKU_CNB_BUILDERlatest tag for the default DOKKU_CNB_BUILDER
|
I'll get this merged, but what is potentially breaking about switching to the |
|
@josegonzalez Thank you for the merge. The breaking differences between the various images are:
The feature parity and language support differences will reduce over the coming months as we finish/polish the native CNBs. See also the image descriptions under the table here: |
|
That is, it would be great if Dokku eventually switched the default to Switching the Dokku default now might be something you want to do anyway (depending on how many people rely on the defaults, your appetite for risk, and how many Dokku users you think might read the release notes clearly etc), but I wanted to at least keep this initial change simple, since it unblocks me deleting the (no longer updated, and IMO footgun-prone) |
|
I'll get a patch release out in a day or two, after which you can probably remove the image. If it breaks for folks, we have a workaround folks can use to switch to a supported builder. I think moving to the |
|
Also, thank you for the explanation, that makes a ton of sense! |
# History ## 0.30.5 Install/update via the bootstrap script: ```shell wget -NP . https://dokku.com/install/v0.30.5/bootstrap.sh sudo DOKKU_TAG=v0.30.5 bash bootstrap.sh ``` ### New Features - #5862: @edmorley Stop using the `latest` tag for the default `DOKKU_CNB_BUILDER` ### Documentation - #5870: @josegonzalez Repair malformed code-block - #5863: @joker234 Remove reference to ssh github clone from app deployment docs ### Tests - #5867: @josegonzalez Update linuxserver image used in tests to one that is compatible with arm64 ### Dependencies - #5868: @josegonzalez Update all golang dependencies to fix go.0 tests - #5856: @dependabot[bot] chore(deps): bump pymdown-extensions from 9.11 to 10.0.1 in /docs/_build - #5865: @dependabot[bot] chore(deps): bump requests from 2.27.1 to 2.31.0 in /tests/apps/lambda-python - #5864: @dependabot[bot] chore(deps): bump mkdocs-material from 9.1.12 to 9.1.14 in /docs/_build - #5866: @dependabot[bot] chore(deps): bump maven-dependency-plugin from 3.5.0 to 3.6.0 in /tests/apps/java
Previously the default value for
DOKKU_CNB_BUILDERwasheroku/buildpacks, which for Docker is equivalent toheroku/buildpacks:latest.The
latesttag is about to be deleted (see heroku/cnb-builder-images#344), so this switches the default value toheroku/buildpacks:20- which is what thelatesttag is currently as alias for.Longer term,
DOKKU_CNB_BUILDERshould be switched to the non-deprecatedheroku/builder:*images, however, that's potentially a breaking change, so is out of scope of this bug-fix PR.For the list of available builders/tags, see:
https://github.com/heroku/builder#heroku-builder-images
Fixes #5861.