Detect id_ed25519.pub in git:public-key command #5786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Probably should also cat the correct file? |
Contributor
Author
|
Ugh, this is what I get for trying to PR before rushing out the door. Sorry @josegonzalez, I'll try to do a decent job later tonight :) |
Contributor
Author
|
OK, now should work as expected @josegonzalez . Tested on a couple of hosts, but not much diversity, all Ubuntu 22.04.1. I think ultimately this would be better served by listing *.pub and pluralizing key, but I think this probably gets us close enough to correct to be worth it (if I didn't flub something obvious again). |
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2023
# History ## 0.30.4 Install/update via the bootstrap script: ```shell wget -NP . https://dokku.com/install/v0.30.4/bootstrap.sh sudo DOKKU_TAG=v0.30.4 bash bootstrap.sh ``` ### Bug Fixes - #5786: @obrienmd Detect id_ed25519.pub in git:public-key command - #5758: @josegonzalez Support pack-based images that do not have a Procfile ### New Features - #5851: @josegonzalez Allow setting _ as domain name for default nginx routing ### Documentation - #5853: @josegonzalez Always overwrite bootstrap install file - #5828: @josegonzalez Add a note to the troubleshooting docs pointing developers to bind to all interfaces - #5827: @josegonzalez Add permalink support to headers ### Tests - #5850: @josegonzalez Only run packer validation if any packer-related files were changed ### Dependencies - #5837: @dependabot[bot] chore(deps): bump golang from 1.20.3 to 1.20.4 in /tests/apps/zombies-dockerfile-tini - #5836: @dependabot[bot] chore(deps): bump golang from 1.20.3 to 1.20.4 in /tests/apps/gogrpc - #5832: @dependabot[bot] chore(deps): bump flask from 2.3.1 to 2.3.2 in /tests/apps/multi - #5831: @dependabot[bot] chore(deps): bump flask from 2.3.1 to 2.3.2 in /tests/apps/python-flask - #5839: @dependabot[bot] chore(deps): bump mkdocs from 1.4.2 to 1.4.3 in /docs/_build - #5835: @dependabot[bot] chore(deps): bump golang from 1.20.3 to 1.20.4 in /tests/apps/zombies-dockerfile-no-tini - #5838: @dependabot[bot] chore(deps): bump golang from 1.20.3 to 1.20.4 in /tests/apps/go-fail-predeploy - #5841: @dependabot[bot] chore(deps): bump golang.org/x/net from 0.9.0 to 0.10.0 in /tests/apps/gogrpc - #5842: @dependabot[bot] chore(deps): bump werkzeug from 2.3.1 to 2.3.4 in /tests/apps/python-flask - #5844: @dependabot[bot] chore(deps): bump django from 4.1.7 to 4.1.9 in /tests/apps/dockerfile-release - #5848: @dependabot[bot] chore(deps): bump mkdocs-material from 9.1.8 to 9.1.12 in /docs/_build - #5840: @dependabot[bot] chore(deps): bump golang from 1.20.3 to 1.20.4 in /tests/apps/go-fail-postdeploy - #5823: @dependabot[bot] chore(deps): bump flask from 2.2.3 to 2.3.1 in /tests/apps/python-flask - #5825: @dependabot[bot] chore(deps): bump flask from 2.2.3 to 2.3.1 in /tests/apps/multi - #5826: @dependabot[bot] chore(deps): bump werkzeug from 2.2.3 to 2.3.1 in /tests/apps/python-flask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue:
#5785