Simplify port handling and centralize all port management in new ports plugin #5548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures users don't set the proxy type to a port map, but also simplifies interactions with ports by giving them their own namespace.
Rather than directly interact with the port map, we now depend on plugin triggers to do so. This allows a further refactor to move the port map to a property instead of having it as a config variable.
This better matches the plugin.
I honestly don't remember what this does and kinda think I'll need to rip it out since it seems inscrutable...
654ab50 to
78c8e76
Compare
Member
Author
|
There is too much going on here. I think I need to redo this PR so that we:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port management is all over the place in the Dokku codebase, and makes certain operations for users more annoying - particularly anything in regards to exposing ports for dockerfile/image-based deployments.
This change centralizes all that logic and removes the dependency on the weird port env vars.
Todo:
DOKKU_PROXY_PORT_MAPto a propertyDOKKU_PROXY_PORTandDOKKU_PROXY_SSL_PORTusageDOKKU_PROXY_PORT_MAPa new property that can be overridden as necessary Reset proxy ports, if no domain is set on first Dockerfile deploy #2903