Exit non-zero when git:from-image deploys fail to start the app #5544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure the repository doesn't get updated to an invalid state in those failure cases. Closes #5538
github-actions bot
pushed a commit
that referenced
this pull request
Dec 29, 2022
# History ## 0.29.3 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.29.3/bootstrap.sh sudo DOKKU_TAG=v0.29.3 bash bootstrap.sh ``` ### Bug Fixes - #5544: @josegonzalez Exit non-zero when git:from-image deploys fail to start the app - #5543: @josegonzalez Properly parse arguments for git:status command ### Tests - #5554: @josegonzalez Validate that procfile-path is respected ### Other - #5551: @dependabot[bot] chore(deps): bump ruby from 3.1.3 to 3.2.0 in /tests/apps/dockerfile-entrypoint - #5547: @dependabot[bot] chore(deps): bump setuptools from 65.5.0 to 65.5.1 in /tests/apps/dockerfile-release - #5542: @josegonzalez Add json output format support to storage:list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure the repository doesn't get updated to an invalid state in those failure cases.
Closes #5538