Fix issue where git:from-image deploys may result in extracted files not being respected #5532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-image This change fixes issues with ps:rebuild not working as expected - essentially ignoring files in the repo - as well as adds tests. Closes #5518
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# History ## 0.29.1 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.29.1/bootstrap.sh sudo DOKKU_TAG=v0.29.1 bash bootstrap.sh ``` ### Bug Fixes - #5532: @josegonzalez Fix issue where git:from-image deploys may result in extracted files not being respected ### Documentation - #5531: @josegonzalez Fix indentation on heading in where to get help - #5521: @AlejandroAkbal Remove reference to `--rm` flag cron task documentation - #5517: @josegonzalez Fix reference to scheduler name in kubernetes docs - #5516: @josegonzalez Fix reference to scheduler name in nomad docs ### Tests - #5533: @josegonzalez Add a test case for nested vector-sink values with plus signs ### Other - #5534: @dependabot[bot] chore(deps): bump sinatra from 3.0.4 to 3.0.5 in /tests/apps/ruby - #5514: @dependabot[bot] chore(deps): bump golang from 1.19.3 to 1.19.4 in /tests/apps/go-fail-predeploy - #5512: @dependabot[bot] chore(deps): bump golang from 1.19.3 to 1.19.4 in /tests/apps/go-fail-postdeploy - #5513: @dependabot[bot] chore(deps): bump golang from 1.19.3 to 1.19.4 in /tests/apps/zombies-dockerfile-no-tini - #5511: @dependabot[bot] chore(deps): bump golang from 1.19.3 to 1.19.4 in /tests/apps/zombies-dockerfile-tini - #5510: @dependabot[bot] chore(deps): bump golang from 1.19.3 to 1.19.4 in /tests/apps/gogrpc - #5525: @dependabot[bot] chore(deps): bump jetty-servlet from 11.0.12 to 11.0.13 in /tests/apps/java - #5519: @dependabot[bot] chore(deps): bump python from 3.11.0-buster to 3.11.1-buster in /tests/apps/dockerfile-release - #5520: @dependabot[bot] chore(deps): bump python from 3.11.0-alpine to 3.11.1-alpine in /docs/_build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes issues with ps:rebuild not working as expected - essentially ignoring files in the repo - as well as adds tests.
It also allows the nginx-conf-sigil-path to be set globally.
Finally, if the image already exists, it is not forcibly pulled. Users should consider using alternative image tags for deploying via
git:from-imageinstead of reusing the same tag.Closes #5518