disable VHOST deployment if global VHOST file is missing and an app domain has not been added #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If a user manually set a domain via the domains plugin, do we want to disable vhosts then? |
Member
Author
|
Fair point. If the answer is no, then this whole feature need some refactoring I think... |
Member
|
If a user uses the domains plugin, that should mean that the app has a vhost. Is that the case with this plugin? |
Member
Author
|
I have something that I think works under that assumption. Writing tests now. |
Member
Author
|
So this update will use a port based deployment if there is no global VHOST and no app vhost but is less aggressive when turning off VHOST support. So you can add a domain even if you have no global VHOST |
josegonzalez
added a commit
that referenced
this pull request
Jan 11, 2015
disable VHOST deployment if global VHOST file is missing and an app domain has not been added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #879