这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@vincentfretin
Copy link
Contributor

herokuish defaults to /tmp/cache, so the build cache don't work without giving the CACHE_PATH environment variable. You can test it with buildstep herokuish branch. cc @progrium

…erokuish

herokuish defaults to /tmp/cache, so the build cache don't work without giving the CACHE_PATH environment variable. You can test it with buildstep herokuish branch. cc @progrium
@michaelshobbs
Copy link
Member

Perhaps this can go into the build-env plugin as a default env var?
Somewhere like here: https://github.com/progrium/dokku/blob/master/plugins/build-env/pre-build#L10

@josegonzalez
Copy link
Member

Why would it need to be in build-env ?

@michaelshobbs
Copy link
Member

This PR is just adding -e CACHE_DIR=/cache to the docker args of the build container. Figured it'd be cleaner to have all build environment variables in the same place.

@josegonzalez
Copy link
Member

Ah makes sense. Seems like it should be in the build-env bit then.

@josegonzalez
Copy link
Member

@vincentfretin mind updating your pr to put it in the right place? :)

@vincentfretin
Copy link
Contributor Author

It doesn't work if I put CACHE_PATH in build-env like CURL_TIMEOUT.
The /app/.env file is read in the main function via buildpack-build which calls buildpack-setup function. The CACHE_PATH is needed before the call to the main function, here: https://github.com/gliderlabs/herokuish/blob/master/include/herokuish.bash#L11

@michaelshobbs
Copy link
Member

Aw bummer. Welp I guess that settles that. 😄

@josegonzalez
Copy link
Member

@michaelshobbs is there a test that might be added for this? I can't think of one, so feel free to merge unless you can.

@michaelshobbs
Copy link
Member

Doesn't look like there is a good place at this point.

michaelshobbs added a commit that referenced this pull request Jan 8, 2015
give CACHE_PATH env variable for forward compatibility with herokuish
@michaelshobbs michaelshobbs merged commit 875da52 into dokku:master Jan 8, 2015
@vincentfretin vincentfretin deleted the patch-3 branch May 16, 2015 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants