@michaelshobbs can you confirm this fix and merge?

👎 on me. Need port on the other lines as well. @andrewsomething can you update? Thanks!

@michaelshobbs Not sure I understand. The goal here is to only show the port when the IP address is being used. That seems to be the only line where that happens, AFICT.

Hrm. I thought I remembered the port being displayed at the end of deploys. @josegonzalez can you confirm?

It is displayed at the end of a deploy, but that is generated using:

echo "$(dokku urls $APP | sed "s/^/       /")"

https://github.com/progrium/dokku/blob/master/dokku#L40

So this will show the port in that case as well.

That is true. However the port is not included in the VHOST file that url/urls is reading from.....but I don't think we need to display the port in the case of using VHOSTs as nginx will be responsible for routing to the container via 443 or 80.

@josegonzalez do you agree with this assessment?

@michaelshobbs I think in his case he doesn't want to use a vhost and just wants to access the app in an ip-based world. In that case, would what url outputs include the port? Probably not.

Yeah I was trying to convince myself that port only makes sense in the IP only case. I think we're all saying the same thing, right?

@andrewsomething

Think so. =)

Cool. LGTM

Thanks! Just a little background on why I care about this usecase... At DigitalOcean we get a lot of users that just want to test out Dokku without having to deal with DNS first. The better that experience, the more likely that they'll want to set something up with Dokku more permanently.

Makes sense. We like dokku adoption! 😄