Disable server tokens in nginx. Closes #857 #858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sure thing. A point of clarification: This will need to be a deployed "unit" test similar to |
Member
|
Thoughts on adding this to the top-level nginx config somewhere around here instead? |
Member
Author
|
Oh thats fine with me. I can change the PR to do that |
josegonzalez
added a commit
that referenced
this pull request
Jan 4, 2015
Disable server tokens in nginx. Closes #857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not merging since there are no tests. @michaelshobbs, do you mind adding tests for this? I'll use that as a guide going forward :)
closes #857