add certificate CN to app VHOST if it's not already #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
071ac5b to
32c88e9
Compare
Member
Author
|
hrm this passes locally with a tty.... |
b7de4ff to
b7091e9
Compare
Member
Author
|
decided to bypass the whole stdin/no tty thing for this unit-test. doesn't add anything to the point of this particular test |
b40e9de to
dba6cce
Compare
dba6cce to
de09260
Compare
Member
|
Well we tell the users what domains they have, so if their cert is invalid, not really our problem :) |
josegonzalez
added a commit
that referenced
this pull request
Dec 25, 2014
add certificate CN to app VHOST if it's not already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will leave a possibility of inadvertently importing an SSL bundle to an app you may not have intended and us making that work.....not sure if that's worse than failing the deploy if the cert's CN isn't in VHOSTS.
closes #845