这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@michaelshobbs
Copy link
Member

@progrium TODOs:

closes #865

@progrium
Copy link
Contributor

progrium commented Jan 6, 2015

Cool! So merge first then those things or merge after?

On Monday, January 5, 2015, Michael Hobbs notifications@github.com wrote:

@progrium https://github.com/progrium TODOs:
[] follow project in CircleCI https://circleci.com/?join=dont-test-alone
[] generate status api token https://circleci.com/docs/status-badges and
send to @michaelshobbs https://github.com/michaelshobbs
[] setup irc notifications https://circleci.com/docs/configuration#notify

closes #865 #865

You can merge this Pull Request by running

git pull https://github.com/expa/dokku mh-circle-ci

Or view, comment on, or merge it at:

#868
Commit Summary

  • try circle again
  • attempt to use make install

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#868.

Jeff Lindsay
http://progrium.com

@josegonzalez
Copy link
Member

I think you can do those first and then merge.

@michaelshobbs
Copy link
Member Author

Yeah I'd like to include the build status badge in this PR

@josegonzalez
Copy link
Member

@progrium bump :)

@progrium
Copy link
Contributor

progrium commented Jan 7, 2015

Okay, I believe I did them all.

On Tue, Jan 6, 2015 at 10:55 AM, Jose Diaz-Gonzalez <
notifications@github.com> wrote:

@progrium https://github.com/progrium bump :)


Reply to this email directly or view it on GitHub
#868 (comment).

Jeff Lindsay
http://progrium.com

@josegonzalez
Copy link
Member

Did you send @michaelshobbs the token for the status badge?

@progrium
Copy link
Contributor

progrium commented Jan 7, 2015

Yes, via email.

On Tue, Jan 6, 2015 at 4:41 PM, Jose Diaz-Gonzalez <notifications@github.com

wrote:

Did you send @michaelshobbs https://github.com/michaelshobbs the token
for the status badge?


Reply to this email directly or view it on GitHub
#868 (comment).

Jeff Lindsay
http://progrium.com

@michaelshobbs
Copy link
Member Author

Got it. I'm afk at the moment but I'll push this as soon as I get back.

@michaelshobbs
Copy link
Member Author

I think we're good to go on this.

josegonzalez added a commit that referenced this pull request Jan 7, 2015
use circleci for automated testing
@josegonzalez josegonzalez merged commit 8502881 into dokku:master Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate testing to CircleCI

3 participants