bind docker container to internal port if using vhosts #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db42f1c to
948d790
Compare
Member
Author
|
Crap! I did not take that into account in this or the previous implementation. I'll take a look in the morning. |
Member
Author
|
Snagged an IPv6 regex from SO (http://stackoverflow.com/questions/53497/regular-expression-that-matches-valid-ipv6-addresses) and put it into the plugin and the domains one as well. |
Member
|
Build failed. Womp. |
Member
Author
|
Docker is having issues according to their rss |
Member
Author
|
Wercker sucks!!!! |
Member
|
lolol |
Member
|
Can you add some docs to this and then we can merge? |
Member
Author
|
Sure thing. Preference on the best place it should live? New md file or existing? |
Member
Author
|
Probably belongs in nginx, no? |
Member
|
In nginx probably. Feel free to reorder stuff as necessary. |
Member
|
Nice work. Merging and shipping a new release :) |
josegonzalez
added a commit
that referenced
this pull request
Jan 6, 2015
bind docker container to internal port if using vhosts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per IRC conversations, this was implemented as a (very simple) pluginhook. Includes tests.
close #860
refs #207
refs #557