Add section to nginx docs about manually updating dokku.conf #3342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I just realized that the reason we don't always overwrite is because of #544. That change is no longer necessary as we do not support global tls as of #2058. Given our stance on always being secure, I'd rather us always overwrite this file instead of telling people to go back and verify that things are done correctly. I'm going to close this in favor of doing that removal. |
Member
|
Thanks for the initial PR! |
josegonzalez
added a commit
that referenced
this pull request
Dec 27, 2018
This is necessary as sometimes older config is shipped with Dokku, meaning that security directives - amongst others - are not properly updated. Refs #3342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: If this PR is just doc changes, please put [ci skip] in the body that way tests do not run.