Remove potentially bad nginx template examples #3069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These examples do not include _all_ of the contents of the original template. Rather than having to keep them up to date and confuse users when we don't, lets just remove them. The section above contains a link to the current `nginx.conf.sigil` and should be referenced by our users instead. Closes #3068 [ci skip]
|
Can't we just provide a link in docs to https://github.com/dokku/dokku/blob/master/plugins/nginx-vhosts/templates/nginx.conf.sigil as an example ? |
|
Thats here. |
|
Yes i just found that, damn man you are fast keep up the good work lesson learned from you thanks ;) |
|
A large bottle of theraflu for my cough. |
josegonzalez
added a commit
that referenced
this pull request
Feb 24, 2018
# History ## 0.11.4 ### Bug Fixes - #3071: @josegonzalez Do not grab restart policies if the deploy phase cannot be read - #3065: @josegonzalez Check if dokkurc files are readable before attempting to source - #3066: @josegonzalez Validate that all application names are valid domain names - #3052: @alexquick Remove bad config keys on load from app/global envfiles ### New Features - #3073: @josegonzalez Add support for rhel - #3039: @josegonzalez Enhance security-related upgrade process - #3038: @shrmnk Add ps:stopall subcommand - #3055: @michaelshobbs Update to herokuish v0.3.34 - #3045: @jcrben Remove nginx configuration files on debian purge ### Documentation - #3072: @josegonzalez Remove all references to VHOST files from documentation - #3069: @josegonzalez Remove potentially bad nginx template examples - #3059: @lwm Add note for runtime host configuration for checks. - #3041: @jcrben Point to unattended install instructions - #3053: @mimischi Add plugin to manage Dockerfile location to documentation - #3062: @shannara Change help run command be more explicit - #3034: @znz Fix a typo in golang config.go source - #3061: @tomdyson Fix plugin-triggers docs typo - #3056: @raine Fix typo in config help output - #3044: @takuti Fix links to port-management - #3042: @josegonzalez Improve documentation around port handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These examples do not include all of the contents of the original template. Rather than having to keep them up to date and confuse users when we don't, lets just remove them. The section above contains a link to the current
nginx.conf.sigiland should be referenced by our users instead.Closes #3068
[ci skip]
Note: If this PR is just doc changes, please put [ci skip] in the body that way tests do not run.