Fix commands, the easy way. #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
|
Let's include this in v0.2.0-RC4 and bump back release 24 more hours |
Don't use pluginhook to run the commands hook, just run all the scripts in a loop.
Now that "docker run" always has an stdin, we don't need to explicitly specify stdout and stderr.
These issues are fixed by this PR.
This avoids hanging when we're not in a pty.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why I haven't thought of it earlier.
This doesn't require a complete refactor, nor changes to pluginhook, as opposed to #312.
I believe the refactor would still be useful and make it cleaner. At least we have an intermediate solution, which we could pull into v0.2, if you agree.
fixes #343 #319 #272 #236