Allow user to modify the repository and tag when deploying an app #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| local cmd="deploy" | ||
| [[ -z $2 ]] && dokku_log_fail "Please specify an app to deploy" | ||
| local APP="$2"; local IMAGE_TAG="$3"; local IMAGE=$(get_app_image_name "$APP" "$IMAGE_TAG") | ||
| local APP="$2"; local IMAGE_TAG="$3"; local IMAGE=$(get_deployed_app_image_name "$APP" "$IMAGE_TAG") |
Member
There was a problem hiding this comment.
i think this is a misnomer. reading that function name makes me think it will return the image name from an app that is already deployed. here we want to know the image name that you want to deploy, right?
something like get_deploying_app_image_name() perhaps?
Member
|
Looks like the |
92776d6 to
8ea5b27
Compare
Uses two new plugin triggers: - deployed-app-repository - deployed-app-image-tag Useful when the image is a custom tagged image on a remote repository
8ea5b27 to
d7566da
Compare
Member
|
@josegonzalez merged but just noticed no docs for new triggers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses two new plugin triggers:
Useful when the image is a custom tagged image on a remote repository
Needs docs for the new hooks and they also should be added to the events plugin.