这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix pre/post deploy support for dockerfile apps #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2016
Merged

Fix pre/post deploy support for dockerfile apps #2065

merged 1 commit into from
Apr 2, 2016

Conversation

@michaelshobbs
Copy link
Member

@michaelshobbs michaelshobbs commented Apr 1, 2016

  • also set pipefail on pre/post deploy tasks

closes #2062

@michaelshobbs michaelshobbs force-pushed the 2062_mh-app-json-exit-on-error branch from 988b186 to c9f4cba Compare April 1, 2016 20:51
josegonzalez
josegonzalez reviewed Apr 1, 2016
View reviewed changes
plugins/00_dokku-standard/exec-app-json-scripts Outdated
local COMMAND+=" echo removing installation cache... ; "
local COMMAND+=" rm -f /tmp/cache || true ; "
local COMMAND+=" exit \$RC "
local COMMAND="set -eo pipefail; [[ \$DOKKU_TRACE ]] && set -x ; "
Copy link
Member

@josegonzalez josegonzalez Apr 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a heredoc for this?

Copy link
Member Author

@michaelshobbs michaelshobbs Apr 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to.

Copy link
Member

@josegonzalez josegonzalez Apr 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@michaelshobbs michaelshobbs force-pushed the 2062_mh-app-json-exit-on-error branch from c9f4cba to 177fc3c Compare April 1, 2016 20:57
@michaelshobbs michaelshobbs force-pushed the 2062_mh-app-json-exit-on-error branch from 177fc3c to 6caed36 Compare April 1, 2016 21:06
@josegonzalez josegonzalez merged commit 0540c25 into master Apr 2, 2016
@josegonzalez josegonzalez deleted the 2062_mh-app-json-exit-on-error branch April 2, 2016 09:12
@josegonzalez josegonzalez changed the title fix pre/post deploy support for dockerfile apps Fix pre/post deploy support for dockerfile apps Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

app.json overrides Docker CMD (dockerfile app)

3 participants

@michaelshobbs @josegonzalez