Fix ps_restart to not exit early #2035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps_restartall_cmd calls ps_restart from a loop, if ps_restart exits because of a not deployed app further apps might not be restarted.
| if is_deployed "$APP"; then | ||
| release_and_deploy "$APP" "$IMAGE_TAG" | ||
| else | ||
| echo "App $APP has not been deployed" |
Member
There was a problem hiding this comment.
Should we return 1 here at least?
Contributor
Author
There was a problem hiding this comment.
I don't think so. After all IMHO that even isn't an error, there's just nothing to be done and then echo just shows a log message. All current callers (ps/subcommands/restartall, nginx-vhosts/proxy-disable and nginx-vhosts/proxy-enable) don't need the information. So YAGNI.
Even worse, if we return 1 here we would have to change all callers (since they set -e they then would exit 1)
Member
|
@michaelshobbs beep beep you're a jeep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ps_restartall_cmd (aka
dokku ps:restartall) calls theps_restartfunction from a loop, so ifps_restartdoes anexit 0if it finds an app that hasn't been deployed (in my case due todokku ps:scale web=0), then it exits theps:restartallloop early and hence just doesn't restart all the apps.