Only chown of existing files #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I added this fix to my 0.4.14 version for ArchLinux to be able to provide a working package. |
plugins/00_dokku-standard/install
Outdated
| chown dokku:dokku "$DOKKU_ROOT/HOSTNAME" "$DOKKU_ROOT/VHOST" | ||
| chown dokku:dokku "$DOKKU_ROOT/HOSTNAME" | ||
|
|
||
| if [[ ! -f "$DOKKU_ROOT/VHOST" ]]; then |
Member
There was a problem hiding this comment.
Am I reading this right? chmod this if it's not a file? Can you clarify here?
Contributor
Author
There was a problem hiding this comment.
-.- Typo. Should be chown
Contributor
Author
There was a problem hiding this comment.
And of course not negated.
Contributor
Author
There was a problem hiding this comment.
It just worked, because I added the VHOST before installation - I retested without the VHOST file and then it works now.
58c5421 to
edf8613
Compare
* this caused issues during installation if the file is not existent
edf8613 to
01430cd
Compare
josegonzalez
added a commit
that referenced
this pull request
Mar 13, 2016
Only chown of existing files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michaelshobbs @josegonzalez This fixed an issue with the ArchLinux installation where the installation of the plugins aborted because the VHOST file was not available. Is this file needed or just optional? Because in Line 9 of this file the VHOST is created only if the host name could be resolved by
dig.