这是indexloc提供的服务，不要输入任何密码
Skip to content

Refactor commands into subcommands and add support for --app argument #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 8, 2016
Merged

Refactor commands into subcommands and add support for --app argument #1953

merged 12 commits into from
Mar 8, 2016

Conversation

@michaelshobbs
Copy link
Member

@michaelshobbs michaelshobbs commented Mar 1, 2016

refs #592 #1039
closes #1579 #1638

@michaelshobbs michaelshobbs force-pushed the 1579_mh-commands_refactor branch 4 times, most recently from bfb1f2e to 0641bba Compare March 3, 2016 02:37
@u2mejc u2mejc mentioned this pull request Mar 3, 2016
Closed
@michaelshobbs michaelshobbs force-pushed the 1579_mh-commands_refactor branch 6 times, most recently from 256dc99 to b3da56c Compare March 4, 2016 02:24
josegonzalez and others added 7 commits March 3, 2016 22:11
@michaelshobbs michaelshobbs force-pushed the 1579_mh-commands_refactor branch 5 times, most recently from b7df78d to 567163c Compare March 4, 2016 20:36
@michaelshobbs michaelshobbs force-pushed the 1579_mh-commands_refactor branch 5 times, most recently from ff353d7 to 1f03523 Compare March 5, 2016 04:19
@michaelshobbs michaelshobbs changed the title subcommands/bashstyle refactor [WIP] subcommands/bashstyle refactor Mar 5, 2016
@michaelshobbs michaelshobbs force-pushed the 1579_mh-commands_refactor branch from 1f03523 to 8159297 Compare March 5, 2016 04:40
@michaelshobbs michaelshobbs force-pushed the 1579_mh-commands_refactor branch from 8159297 to d8e00f4 Compare March 5, 2016 04:59
@michaelshobbs michaelshobbs changed the title [WIP] subcommands/bashstyle refactor subcommands/bashstyle refactor Mar 5, 2016
josegonzalez
josegonzalez reviewed Mar 8, 2016
View reviewed changes
docs/development/plugin-creation.md Outdated
```


### Sample plugin - old structure (still supported but not advised)
Copy link
Member

@josegonzalez josegonzalez Mar 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the old method. One true way.

Copy link
Member Author

@michaelshobbs michaelshobbs Mar 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@josegonzalez
Copy link
Member

josegonzalez commented Mar 8, 2016

👍

michaelshobbs added a commit that referenced this pull request Mar 8, 2016
@michaelshobbs
Merge pull request #1953 from dokku/1579_mh-commands_refactor
37584be 
subcommands/bashstyle refactor
@michaelshobbs michaelshobbs merged commit 37584be into master Mar 8, 2016
@michaelshobbs michaelshobbs deleted the 1579_mh-commands_refactor branch March 8, 2016 21:35
@josegonzalez josegonzalez changed the title subcommands/bashstyle refactor Refactor commands into subcommands and add support for --app argument Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plugin command structure

3 participants

@michaelshobbs @josegonzalez