Fix get_running_image_tag() with docker 1.10.x #1934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is also backwards compatible with docker |
Member
|
Why not just always use docker inspect? Hopefully they break that interface less often... |
Member
Author
|
Sometimes we just want running containers. |
josegonzalez
added a commit
that referenced
this pull request
Feb 22, 2016
fix get_running_image_tag() with docker 1.10.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker 1.10.x changed the format of
docker ps -a; which we should rely on anyway. This change usesdocker inspectoutput instead. All other instances ofdocker ps ...| egrep ...are simplistic enough for now.