-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Refactor nginx proxy plugin to add usage flexibility #1892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we list the udp and tcp ports separately? And pass them in somehow to the enabled proxy plugin. That way the plugin can do as it wants. I think we disable the proxy plugin and treat it like a background app for our nginx implementation. Nothing else we can do anyhow. |
c5966bf to
dd9adb1
Compare
|
@josegonzalez I'm not clear on the context of your two sections there. Can you clarify please? |
|
|
Ah ok. Haven't even touched dockerfile stuff yet but I play around with some test deploys and report back. |
bcac7a1 to
b9c8f71
Compare
e98dbf7 to
edd958d
Compare
edd958d to
56e1527
Compare
plugins/00_dokku-standard/functions
Outdated
| source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions" | ||
| source "$PLUGIN_CORE_AVAILABLE_PATH/proxy/functions" | ||
|
|
||
| get_app_urls() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consolidate the common and 00_dokku-standard plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably.
|
Disable the proxy == no zero-downtime. Ports just change. Want a light-weight way of having the same ports without the overhead of nginx or haproxy? Create a proxy plugin that does it via iptables. I don't particularly like the idea of:
Sounds risky, people will complain that their apps don't work, and will be a mess to keep track of. |
|
I mean it was a "feature" of dokku years ago if there was port collision, the old container was simply shut down first. But I'll defer to you guys since I don't utilize the use case, so I have not vested interest. |
|
Do you have docs for that feature? |
76a5d5d to
0fb63b7
Compare
|
Fixed This dockerfile Yields these URLS: |
|
Please let me know if I missed anything here |
7f750bf to
d8b94f1
Compare
you have to go way back! like here: Line 31 in cf7a2a0
But I think it's a mute issue. I'll poke around more today. |
|
@josegonzalez I'd like to drop the custom template path variable and support it similarly to how we handle the |
|
What do you mean? |
|
Meaning we'll search for it in |
|
I don't like the additional complexity it adds and we don't support this anywhere else. Additionally there is a community plugin to help store your "dokku-isms" in a subfolder and move them appropriately at deploy time. |
|
Fine by me, just document it. |
|
Ah! That plugin is out of date but the point still stands about additional complexity and it being the only place we support this sort of custom pathing. Feels janky. |
|
@josegonzalez I'll need @pmclanahans's changes to |
8c5b6c6 to
1e6dcff
Compare
1e6dcff to
9842d74
Compare
|
Time to break any installs of master! |
|
@sseemayer This is maybe interesting for the Let's encrypt plugin. I guess the plugin should be ported to the new templating. |
This is a work in progress, PLEASE DO NOT MERGE. I wanted to get this up for initial feedback. The following checklist will show current progress. Please pick this apart!
MakefileNO_VHOSTvariable. explicitly usedomains:disable/domains:enablenginx.conf.sigil)/apporWORKDIRopen questions:
include {{ .DOKKU_ROOT }}/{{ .APP }}/nginx.conf.d/*.conf;this can be handled via a custom template nowcloses #1629