Support bash 4.2 so we don't have to modify all plugin test envs #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @u2mejc @josegonzalez |
6c24387 to
33eeeb8
Compare
33eeeb8 to
33c6e56
Compare
Member
|
Closing, this is no longer necessary since i just updated all the envs... |
michaelshobbs
added a commit
that referenced
this pull request
Jan 18, 2016
support bash 4.2 so we don't have to modify all plugin test envs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My thinking here is if we’re going to have a baseline bash version requirement, then we should have a damn good reason for it. Currently, there is no real need to support
bash>=4.3; especially not for just one line of code.Given that this PR is so small and still maintains
bash<4.3support, I think it’s reasonable to maintain that support for now. If we end up finding ourselves having to go through uncomfortable machinations to supportbash>=4.2, then we punt and force thebash>=4.3requirement.