这是indexloc提供的服务，不要输入任何密码
Skip to content

Add skip_keyfile option for deb package #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2016
Merged

Add skip_keyfile option for deb package #1855

merged 1 commit into from
Jan 14, 2016

Conversation

@jvanbaarsen
Copy link
Contributor

@jvanbaarsen jvanbaarsen commented Jan 11, 2016

There are cases where we don't want the check for keyfile, this will add a
config option, that allows you to skip this particular check.

Fixes #1851

This was referenced Jan 11, 2016
Closed
Closed
Merged
@josegonzalez
Copy link
Member

josegonzalez commented Jan 11, 2016

  • What happens if this value isn't set?
  • Doesn't this need to be handled somehow here?
  • Do we need a debconf template for it here?

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 11, 2016

@josegonzalez Let me check every one of those cases!

For the template, I only feel that is needed if we also document this feature, what do you think?

@josegonzalez
Copy link
Member

josegonzalez commented Jan 11, 2016

Oh yeah, this also needs to be documented.

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 11, 2016

👍 On it!

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 11, 2016

@josegonzalez When I add the following to debian/config, the installation will break:

db_input "high" "dokku/skip_key_file" || false

Can I only put true on the right side?

@josegonzalez
Copy link
Member

josegonzalez commented Jan 11, 2016

Idk @3onyc implemented this. You're gonna have to go debian packaging spelunking :D

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 11, 2016

@josegonzalez Ok, what about I just make sure I get it to work for the old scenario, and the new scenario, If that works without touching the config, would that be ok for you?

@josegonzalez
Copy link
Member

josegonzalez commented Jan 11, 2016

Yeah. The following should work:

  • Fresh install with web config
  • Fresh install/Upgrade with debconf
  • Fresh install/Upgrade with prompts

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 11, 2016

@josegonzalez Also, when I add it to the template file, it will ask in the GUI prompts if you want to skip the key_file. I feel that should not be there, right? Since its only for fully unattended installations?

@josegonzalez
Copy link
Member

josegonzalez commented Jan 11, 2016

If thats the case, I guess you can leave it off.

@3onyc
Copy link
Contributor

3onyc commented Jan 11, 2016

@jvanbaarsen If I recall correctly only items listed in debian/config get asked to the user, so dokku/skip_key_file shouldn't be in there. However it should be added to debian/templates

Also, looking at your use case, you're already asking for IP/port to install Dokku, can't you also prompt for a public key there?

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 11, 2016

@3onyc I'm skipping those questions as well with the config setters. Why should it be in debian/templates though?

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 12, 2016

@josegonzalez I feel like this is ready to be merged

@3onyc
Copy link
Contributor

3onyc commented Jan 12, 2016

@jvanbaarsen It's the standard file to define all debconf values in, if we omit it Debian packaging related utilities won't know it exists.

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 12, 2016

@3onyc I don't think that is a problem, since it mostly there for people that know what it is for. And not really for general use. @josegonzalez Opinion?

@josegonzalez
Copy link
Member

josegonzalez commented Jan 12, 2016

I would go with what @3onyc says.

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 12, 2016

👍

@jvanbaarsen
Add skip_keyfile option for deb package
2a4155a 
There are cases where we don't want the check for keyfile, this will add a
config option, that allows you to skip this particular check.

Fixes dokku#1851

Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 12, 2016

@josegonzalez Updated PR

@josegonzalez
Copy link
Member

josegonzalez commented Jan 12, 2016

@3onyc I'll wait on your decision before merging :)

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 14, 2016

@3onyc Bump :-)

josegonzalez added a commit that referenced this pull request Jan 14, 2016
@josegonzalez
Merge pull request #1855 from jvanbaarsen/add-skip-keyfile
a2b775a 
Add skip_keyfile option for deb package
@josegonzalez josegonzalez merged commit a2b775a into dokku:master Jan 14, 2016
@3onyc
Copy link
Contributor

3onyc commented Jan 15, 2016

Already merged, but 👍.

@jvanbaarsen
Copy link
Contributor Author

jvanbaarsen commented Jan 15, 2016

@3onyc / @josegonzalez Thanks!

@jvanbaarsen jvanbaarsen deleted the add-skip-keyfile branch January 15, 2016 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvanbaarsen @josegonzalez @3onyc