Make sure we ignore hidden files in the SSL cert check #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSX creates hidden files: `./._server.key` and `./._server.crt`. The Dokku cert plugin is choking on those files. We should probably just ignore them, and go on with our lives Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
Member
|
👍 Thanks for adding tests too!! 😍 |
michaelshobbs
added a commit
that referenced
this pull request
Jan 6, 2016
Make sure we ignore hidden files in the SSL cert check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSX creates hidden files:
./._server.keyand./._server.crt. The Dokku certplugin is choking on those files. We should probably just ignore them, and go on
with our lives
Fixes #1832
Ref #1831