Write out /home/dokku/HOSTNAME as specified by the web installer. #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
This block should go write below the previous with open call.
Contributor
Author
There was a problem hiding this comment.
Shouldn't it be outside of the if ... else? I think HOSTNAME should get written regardless of whether or not virtualhost naming is used, no?
Member
|
OOPS! Good catch! |
josegonzalez
added a commit
that referenced
this pull request
Jan 4, 2016
Write out /home/dokku/HOSTNAME as specified by the web installer.
Member
|
Thanks for the pr! I'll try and make a release tonight. |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Just a quick little fix for the web installer. When ported to Python, it looks like writing out the value of the hostname field to
/home/dokku/HOSTNAMEwas accidentally dropped and only/home/dokku/VHOSTis written.Compare to the current implementation to the current one, specifically:
dokku/contrib/dokku-installer.rb
Line 55 in 32f1bc5