Fully-tested debian packaging for modern Ubuntu/Debian distributions #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d systemd We should only create the upstart version if the OS does not use systemd.
- Use the nginx.conf file's existence as a check for whether we should start the service or not - Create the init files with the dokku-installer.py file. This adds actual systemd support. - Also ensure we *always* start the service, regardless of it's status. This fixes an issue with processing systemd output
Contributor
|
Sweet. Let me know if I can help with testing anything. |
This reverts commit 3fb59fd. Changing the path to dokku cannot be done in a patch release, as it would break existing sshcommand entries.
…start and systemd" This reverts commit 1581884.
We previously assumed that systemd was detectable by the existence of certain directories. Unfortunately, it seems 14.04 already has these directories, so we need to handle this case separately. One other note is that dokku-installer will fail to "start" if already started on certain systems, thus the previous grep was more accurate in it's running.
- remove deployed applications during dpkg purge - disable all core plugins during dpkg purge - ensure init files are removed - ensure motd is removed - remove all core plugins, dokku config files (including tls/sshcommand entries etc.) during purge - remove all empty directories and broken symlinks in the DOKKU_ROOT and DOKKU_LIB_ROOT directories during purge Note that we do not delete the dokku user itself as there might be other data we don't know about in this directory.
They will cease to function regardless of whether the package has been purged or not
Otherwise we run the risk of proxying a request to a bad backend
Contributor
|
Just tying things together, by leaving a note here regarding a challenge with Ubuntu 15.10 (and maybe soon 16.04): #2034 |
Member
|
@MikeSchroll what's the issue? |
Member
Author
|
Looks like wily has this package available as the thing that broke #2034. sigh I'll take a look at renaming the package, though if someone installs both, they are hosed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: