Allow updating submodules at any revision #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `--depth=1` breaks any submodules that are not at HEAD
Member
Author
|
I'm going to merge this without comment. It breaks existing applications that don't use HEAD of their submodules, which I think is pretty bad. We can't do a @mmerickel feel free to revisit this since I know it's a painful topic for you :( |
josegonzalez
added a commit
that referenced
this pull request
Jan 3, 2016
Allow updating submodules at any revision
Contributor
|
No problem, I shouldn't have thrown the submodule fix in there. It's not a feature I use myself. I naively assumed that --depth=1 would clone the commit the submodule was pinned to... not just head. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
--depth=1breaks any submodules that are not at HEAD./cc @mmerickel