Replace dokku-installer.rb with dokku-installer.py #1794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f2a351 to
8596719
Compare
8596719 to
e323770
Compare
Member
Author
|
Tested against ubuntu and works fine :) |
Member
|
I'm +1 for anything that |
Member
Author
|
I'm going to merge this. If there are any issues in usage, we can sort them out after the release. |
josegonzalez
added a commit
that referenced
this pull request
Dec 22, 2015
Replace dokku-installer.rb with dokku-installer.py
|
LGTM! Thanks for this. Unfortunately I don't really have the skills/time to quickly test it on a fresh Debian install right now, but I don't see why it wouldn't work. Will make sure to try it next time I install dokku on Debian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python version should allow us to remove any ruby dependencies and should also slightly speed up dokku installation. All LSB-compliant distributions should have python, so we should be okay depending upon it.
Closes #1783
Closes #1786