Make it possible to skip a deploy #1789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You'll need to rebase this in order to get tests to pass. |
plugins/common/functions
Outdated
Member
There was a problem hiding this comment.
We'll probably want to support global with an override. See this as an example: https://github.com/dokku/dokku/blob/v0.4.6/dokku#L96-L102
Contributor
Author
|
Rebased and updated to add support for global setting. For some reason the test are still failing though. |
Contributor
Author
|
Ah, it seems it was a temporary problem. Looks green now. |
plugins/common/functions
Outdated
Member
There was a problem hiding this comment.
Sorry I missed this in the first pass, but following our coding style guide, can you swap out the deprecated [ for the preferred [[? Thanks!
Contributor
Author
There was a problem hiding this comment.
Right! I'll try to fix it ASAP (I'm on a train and have bad connectivity, atm)
michaelshobbs
added a commit
that referenced
this pull request
Dec 22, 2015
Make it possible to skip a deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale here is to make it possible to
git push dokku mastera base image that is used by other applications that are effectively being deployed.Used in this manner, Dokku becomes a lightweight alternative to a private Docker registry.