Remove shebang from config/functions #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be one step closer to lintian compliance, lets remove the shebang from this file so it doesn;t have to be executable See dokku#1641 Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
Member
|
Note: we still don't have tests running on CircleCI. They are aware of the issue and investigating. Merging as I've tested this change locally. |
josegonzalez
added a commit
that referenced
this pull request
Dec 10, 2015
Remove shebang from config/functions
Contributor
Author
|
@josegonzalez What are the issues with Circle? |
Member
|
They apparently can't seem to enable it because I'm somehow not an admin of the dokku org in their system... |
Contributor
Author
|
@josegonzalez Ah ok, did you consider an alternative? (Semaphore maybe?) |
Member
|
No, I haven't. I think @michaelshobbs is looking into it. If anything, we'll setup our own CI on Digital Ocean. They sponsor us so we can probably setup an internal jenkins thing or similar to run tests. |
Contributor
Author
|
ah ok :-) I hope the semaphore / circle solutions works though :) Otherwise its another thing you have to maintain ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be one step closer to lintian compliance, lets remove the shebang
from this file so it doesn;t have to be executable
See #1641