Make dokku play nice when we have multiple receive-app hooks #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What is the use case of multiple |
Member
|
He wants to use both mercurial and git for deployments. As is, the output of one of them is eaten up, so deploy output isn't very useful :( |
Member
There was a problem hiding this comment.
Can you add context here?
Contributor
Author
There was a problem hiding this comment.
If you run ps:rebuild, but the application is not backed by git, you get an ugly error message to that effect from git. Also its my understanding that if your plugin doesn't wish to act, that it should exec cat so that the messages on std out by other processes get passed though.
Basically we only want to call git-build if we are building a git based app.
b9edc42 to
98990b6
Compare
josegonzalez
added a commit
that referenced
this pull request
Aug 24, 2015
Make dokku play nice when we have multiple receive-app hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.