这是indexloc提供的服务，不要输入任何密码
Skip to content

Make bootstrap.sh safe from bad connection #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2015
Merged

Make bootstrap.sh safe from bad connection #1366

merged 2 commits into from
Aug 12, 2015

Conversation

@omeid
Copy link
Contributor

@omeid omeid commented Aug 4, 2015

This allows to run the bootstrap.sh directly and "safely" without storing it on disk.

@josegonzalez
Copy link
Member

josegonzalez commented Aug 4, 2015

@michaelshobbs ?

@omeid
Make bootstrap.sh safe from bad connection
777a098 
This allows to run the bootstrap.sh directly and "safely" without storing it on disk.

Signed-off-by: O'meid <public@omeid.me>
@michaelshobbs
Copy link
Member

michaelshobbs commented Aug 10, 2015

my only concern is variable scoping but it's probably ok. @omeid can you test this with different $DOKKU_TAG and $DOKKU_REPO env vars?

@omeid
Copy link
Contributor Author

omeid commented Aug 11, 2015

Works just fine for me.

$ curl https://raw.githubusercontent.com/omeid/dokku/patch-1/bootstrap.sh | DOKKU_TAG=v0.2.0 DOKKU_REPO="https://github.com/omeid/dokku.git" bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2719  100  2719    0     0   5058      0 --:--:-- --:--:-- --:--:--  5053
Preparing to install v0.2.0 from https://github.com/omeid/dokku.git...
Ign http://archive.ubuntu.com trusty InRelease
Ign http://archive.ubuntu.com trusty-updates InRelease
Ign http://archive.ubuntu.com trusty-security InRelease
25% [Working]^C
$
`

@michaelshobbs
Copy link
Member

michaelshobbs commented Aug 11, 2015

👍

@omeid
Copy link
Contributor Author

omeid commented Aug 11, 2015

It would be nice if bootstrap.dokku.io pointed to https://raw.github.com/progrium/dokku/$LATEST/bootstrap.sh

@michaelshobbs
Copy link
Member

michaelshobbs commented Aug 11, 2015

Who owns dokku.io...?

@omeid
Copy link
Contributor Author

omeid commented Aug 12, 2015 

$ whois dokku.io
[Querying whois.nic.io]
[whois.nic.io]

Domain : dokku.io
Status : Live
Expiry : 2016-01-04

NS 1   : dns1.registrar-servers.com
NS 2   : dns2.registrar-servers.com
NS 3   : dns3.registrar-servers.com
NS 4   : dns4.registrar-servers.com
NS 5   : dns5.registrar-servers.com

Owner  : Ernst Rijsdijk
Owner  : Noordgouw 28
Owner  : Ursem
Owner  : Noord-Holland
Owner  : NL
`

@michaelshobbs
Copy link
Member

michaelshobbs commented Aug 12, 2015

Yup I did the same thing. No idea who that is.

@omeid
Copy link
Contributor Author

omeid commented Aug 12, 2015

No idea either.

@josegonzalez
Copy link
Member

josegonzalez commented Aug 12, 2015

I've tried reaching out to that guy, no response. If anyone wants to do that for us, that would be pretty pro.

josegonzalez added a commit that referenced this pull request Aug 12, 2015
@josegonzalez
Merge pull request #1366 from omeid/patch-1
5a5e803 
Make bootstrap.sh safe from bad connection
@josegonzalez josegonzalez merged commit 5a5e803 into dokku:master Aug 12, 2015
@omeid
Copy link
Contributor Author

omeid commented Aug 13, 2015

@josegonzalez It is important that the domain ownership is passed on to the owner/maintainer of dokku though. Having two trust points for this sort of "run remote code on the fly" is kinda less than optimal.

@josegonzalez
Copy link
Member

josegonzalez commented Aug 13, 2015

@omeid we never refer to dokku.io anywhere, and it's not like we're telling people to install code from a domain other than a github-controlled domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omeid @josegonzalez @michaelshobbs