这是indexloc提供的服务，不要输入任何密码
Skip to content

only run domains and nginx config if we have a port and ip #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2015
Merged

only run domains and nginx config if we have a port and ip #1357

merged 1 commit into from
Jul 31, 2015

Conversation

@michaelshobbs
Copy link
Member

@michaelshobbs michaelshobbs commented Jul 30, 2015

  • only run domains:setup and nginx:build-conifg if IP.web.1 and PORT.web.1 files exist
  • added test app that just contains a worker process

fixes #1355

@michaelshobbs michaelshobbs changed the title only run domains and nginx config if we have a port and ip. fixes #1355 only run domains and nginx config if we have a port and ip Jul 30, 2015
@josegonzalez
Copy link
Member

josegonzalez commented Jul 31, 2015

Does this work for apps that have multiple web procs?

@michaelshobbs
Copy link
Member Author

michaelshobbs commented Jul 31, 2015

Yes. We test scaling and those tests pass.

josegonzalez added a commit that referenced this pull request Jul 31, 2015
@josegonzalez
Merge pull request #1357 from progrium/1355_mh-deploy-no-webproc
b371bca 
only run domains and nginx config if we have a port and ip
@josegonzalez josegonzalez merged commit b371bca into master Jul 31, 2015
@josegonzalez josegonzalez deleted the 1355_mh-deploy-no-webproc branch July 31, 2015 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot deploy without web process

3 participants

@michaelshobbs @josegonzalez