Add nginx:access-logs and nginx:error-logs. #1352
Conversation
Add two nginx subcommands to display nginx error/access logs for a particular app.
There was a problem hiding this comment.
I think this can be pared down to /usr/bin/tail /var/log/nginx/* and /usr/bin/tail -f /var/log/nginx/*. Test this of course. 😄
There was a problem hiding this comment.
The more I think about it, allowing any user with access to the dokku account to tail any file, is a security risk I don't think is worth introducing.
There was a problem hiding this comment.
After doing the plugin plugin, I remembered that we assume dokku will be run by root and thus we sudo su - dokku here: https://github.com/progrium/dokku/blob/63d89942438e2806c5322c2ecddbe2d008e03f42/dokku#L44-L47
Therefore I think we can just filter these commands as well to make them not sudo. I'll create a new PR based on this work.
|
@isundaylee mind updating the PR to match expectations? |
|
Closing in favor of #1469. Thanks for your work @isundaylee! |
Add two nginx subcommands to display nginx error/access logs for a particular app.
closes #1159