[bugfix] in nginx.conf.template getting from /app directory #1331
Conversation
There was a problem hiding this comment.
Doesn't $APP_NGINX_TEMPLATE need to be the full path?
There was a problem hiding this comment.
As I tested it - no. You should define only directory where template should be stored. If you use $APP_NGINX_TEMPLATE as the full path, docker will create directory with this name, not the file.
There was a problem hiding this comment.
👍 on fixing $DOKKU_APP_CIDS. I missed that one in review. Any reason to change from using $APP_NGINX_TEMPLATE? I like variable re-use. 😄
EDIT: @alexkruegger, I didn't see your comment before posting. @josegonzalez I was incorrect in my testing method. @alexkruegger's comment is definitely correct.
There was a problem hiding this comment.
:) Thank you for nice tool and fast response! Happy coding! )
[bugfix] in nginx.conf.template getting from /app directory
There is bugfix for ability to get 'nginx.conf.template' from original repository. The bug is small and fix is just syntax correction.