Set X-Forwarded-Proto header if TLS is enabled when running checks #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems reasonable. Have you used this in a live environment? |
Contributor
Author
|
I have (only) tested the change with this simple Express app: app.enable('trust proxy')
app.get('/', function(request, response) {
if(!request.secure) {
return response.redirect(301, 'https://' + request.get('Host') + request.url)
}
response.send('Hello World!')
}) |
Member
|
#1300 comes with some test fixes. can you rebase once I merge that? |
Contributor
Author
|
No problem. |
Member
|
g2g |
michaelshobbs
added a commit
that referenced
this pull request
Jul 9, 2015
Set X-Forwarded-Proto header if TLS is enabled when running checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I have an app which only responds to HTTPS requests (or redirects non-secure requests to HTTPS) any checks defined in the
CHECKSfile will fail. This isn’t a problem for “real requests” as nginx sets theX-Forwarded-Protoheader accordingly.I therefore suggest setting the
X-Forwarded-Protoheader tohttpswhen running checks against a TLS-enabled app.