这是indexloc提供的服务，不要输入任何密码
Skip to content

initial pass at config plugin arguments refactor #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2015
Merged

initial pass at config plugin arguments refactor #1291

merged 2 commits into from
Jul 10, 2015

Conversation

@michaelshobbs
Copy link
Member

@michaelshobbs michaelshobbs commented Jul 7, 2015

  • adds --global for managing $DOKKU_ROOT/ENV
  • adds [config:set|config:unset] --no-restart
  • deprecates config:set-norestart and config:unset-norestart
root@dokku:~/dokku# dokku config --global
=====> global config vars
CURL_CONNECT_TIMEOUT: 5
CURL_TIMEOUT:         30

root@dokku:~/dokku# dokku config:set --no-restart node-js-app testing=true
-----> Setting config vars
       testing: true

@michaelshobbs
Copy link
Member Author

michaelshobbs commented Jul 7, 2015

refs: #1261

josegonzalez
josegonzalez reviewed Jul 7, 2015
View reviewed changes
plugins/backup/commands
Copy link
Member

@josegonzalez josegonzalez Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol when are these rando-spaces going away?

Copy link
Member Author

@michaelshobbs michaelshobbs Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you fix them, duh! 😈

EDIT: or when I do #1292

Copy link
Member

@josegonzalez josegonzalez Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

michaelshobbs
michaelshobbs reviewed Jul 7, 2015
View reviewed changes
plugins/config/commands
Copy link
Member Author

@michaelshobbs michaelshobbs Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strips trailing $ from output of read -r

@michaelshobbs
Copy link
Member Author

michaelshobbs commented Jul 9, 2015

blocks #1261

@michaelshobbs michaelshobbs mentioned this pull request Jul 9, 2015
Merged
@josegonzalez
Copy link
Member

josegonzalez commented Jul 10, 2015

Looks good to me. Merge when ready :)

michaelshobbs added a commit that referenced this pull request Jul 10, 2015
@michaelshobbs
Merge pull request #1291 from progrium/1261_mh-config-args-refactor
4629a99 
initial pass at config plugin arguments refactor
@michaelshobbs michaelshobbs merged commit 4629a99 into master Jul 10, 2015
@josegonzalez josegonzalez deleted the 1261_mh-config-args-refactor branch July 10, 2015 15:13
@tilgovi tilgovi mentioned this pull request Aug 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelshobbs @josegonzalez