这是indexloc提供的服务，不要输入任何密码
Skip to content

don't background cleanup #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2015
Merged

don't background cleanup #1289

merged 1 commit into from
Jul 6, 2015

Conversation

@michaelshobbs
Copy link
Member

@michaelshobbs michaelshobbs commented Jul 6, 2015

This should prevent this random event from happening in the future:

Counting objects: 10, done.
Delta compression using up to 32 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (10/10), 1.50 KiB | 0 bytes/s, done.
Total 10 (delta 0), reused 0 (delta 0)
remote: -----> Cleaning up...
remote: -----> Building test-java-32254 from buildstep...
remote: time="2015-07-06T03:40:34Z" level="fatal" msg="Error response from daemon: No such container: f516ef28a768b1955144a3c3f866e49963284372e2aa90c05371882306a322b9" 
To dokku@dokku.me:test-java-32254
 ! [remote rejected] master -> master (pre-receive hook declined)

I've been running this in production for a few months now and no longer experience the no such container error during deploys.

@michaelshobbs
Copy link
Member Author

michaelshobbs commented Jul 6, 2015

@josegonzalez thoughts?

@josegonzalez
Copy link
Member

josegonzalez commented Jul 6, 2015

Looks good to me :)

michaelshobbs added a commit that referenced this pull request Jul 6, 2015
@michaelshobbs
Merge pull request #1289 from progrium/mh-fix-random-test-failure
aa55f02 
don't background cleanup
@michaelshobbs michaelshobbs merged commit aa55f02 into master Jul 6, 2015
@josegonzalez josegonzalez deleted the mh-fix-random-test-failure branch July 6, 2015 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelshobbs @josegonzalez