-
-
Notifications
You must be signed in to change notification settings - Fork 2k
fixes #1270 faulty default container check #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I thought we were doing to use a different method than Honestly I'd prefer dropping all processing of |
|
@kilianc can you update this pr to use the docker command directly? |
|
sure thing |
|
test are failing, can you guys look up why? not sure it's me |
|
it looks like its the default container check when i look at the ci output. can you try running the tests locally? |
|
I need to figure out how :) @michaelshobbs |
export DOKKU_APP_CONTAINER_ID=$(docker ps -q --no-trunc | head -1)
echo $DOKKU_APP_CONTAINER_ID
docker top "$DOKKU_APP_CONTAINER_ID" &>/dev/null || echo "App container failed to start $DOKKU_APP_CONTAINER_ID"
docker top "$DOKKU_APP_CONTAINER_ID" &>/dev/null && echo "Container is running $DOKKU_APP_CONTAINER_ID"
docker top "$DOKKU_APP_CONTAINER_ID"a &>/dev/null || echo "App container failed to start $DOKKU_APP_CONTAINER_ID"
docker top "$DOKKU_APP_CONTAINER_ID"a &>/dev/null && echo "Container is running $DOKKU_APP_CONTAINER_ID"this works on my ubuntu |
|
circleci's docker daemon responds with an error .... |
|
for reference: |
|
@michaelshobbs we can use docker inspect but we need to handle "true" "false" and exit code |
|
moby/moby#7993 seems a problem with the vm running the test? |
|
i'll hit up circle about the |
|
btw I think ps:stop has the same issue. it says the container is stopped when it's running instead |
|
@kilianc were you going to attempt to rework this with |
No description provided.