这是indexloc提供的服务，不要输入任何密码
Skip to content

allow passing of docker build options and document dockerfile deployment. closes #1231 #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2015
Merged

allow passing of docker build options and document dockerfile deployment. closes #1231 #1232

merged 2 commits into from
Jun 15, 2015

Conversation

@michaelshobbs
Copy link
Member

@michaelshobbs michaelshobbs commented Jun 15, 2015

  • documents Dockerfile deployments
  • exposes $DOKKU_DOCKERFILE_CACHE_BUILD for specific control of --no-cache on docker build
  • exposes $DOKKU_DOCKER_BUILD_OPTS for injection of any docker build option
  • sources $DOKKU_ROOT/$APP/ENV on dokku build

@michaelshobbs michaelshobbs mentioned this pull request Jun 15, 2015
Closed
Flink
Flink reviewed Jun 15, 2015
View reviewed changes
docs/application-deployment.md Outdated
Copy link
Contributor

@Flink Flink Jun 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be had => typo?

@Flink
Copy link
Contributor

Flink commented Jun 15, 2015

Is DOKKU_DOCKERFILE_CACHE_BUILD really useful since DOKKU_DOCKER_BUILD_OPTS seems to be a better way to achieve the same thing (and more flexible)?

@michaelshobbs michaelshobbs mentioned this pull request Jun 15, 2015
Closed
@hhff
Copy link
Contributor

hhff commented Jun 15, 2015

👍

@michaelshobbs michaelshobbs force-pushed the 1231_mh-dockerfile-build-cache-control branch from a162a48 to ea66619 Compare June 15, 2015 16:00
@michaelshobbs
Copy link
Member Author

michaelshobbs commented Jun 15, 2015

@Flink $DOKKU_DOCKERFILE_CACHE_BUILD is meant to be an easy "on/off switch" and $DOKKU_DOCKER_BUILD_OPTS is for more "advanced" purposes. The former seems easiest for those not wanting to know about the specifics of the docker cli.

@Flink
Copy link
Contributor

Flink commented Jun 15, 2015

@michaelshobbs Ok works for me 😉 👍

michaelshobbs added a commit that referenced this pull request Jun 15, 2015
@michaelshobbs
Merge pull request #1232 from progrium/1231_mh-dockerfile-build-cache…
6ebb897 
…-control

allow passing of docker build options and document dockerfile deployment. closes #1231
@michaelshobbs michaelshobbs merged commit 6ebb897 into master Jun 15, 2015
@josegonzalez josegonzalez deleted the 1231_mh-dockerfile-build-cache-control branch June 16, 2015 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelshobbs @Flink @hhff