Fix broken ssl wildcard redirect #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use nginx $host variable intead of $ssl_server_nam (which may be *.example.com) which does bogus redirects
Member
|
Are you sure this is still an issue in master? Ostensibly this was fixed via #1202 |
Contributor
Author
|
Im using Dokku v0.3.17 Even then, using nginx $host is a better solution than just dumping the domain variable from the bash script into the nginx config |
Member
|
As a side note, you could also provide your own template for these apps instead. Your explanation makes sense. I'm wondering if we're breaking any assumptions or expected behaviors with this change. @lmars @josegonzalez thoughts on this? |
Member
|
I'm okay with this change, makes sense to me, so long as tests pass :) |
Member
|
👍 |
michaelshobbs
added a commit
that referenced
this pull request
Jun 5, 2015
…sl_wildcard_redirect Fix broken ssl wildcard redirect
Contributor
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Actual:
http://example.com > https://example.com (works as it should)
http://test.example.com > https://.example.com (BROKEN)
http://api.example.com > https://.example.com (BROKEN)
http://app.example.com > https://.example.com (BROKEN)
( https://.example.com may appear as https://%2A.example.com depending on browser)
Example Expected:
http://example.com > https://example.com (works as it should)
http://test.example.com > https://test.example.com (Expected)
http://api.example.com > https://api.example.com (Expected)
http://app.example.com > https://app.example.com (Expected)
nginx redirects to https://*.example.com/ which is a bogus url due to the $SSL_SERVER_NAME in the nginx template
Use nginx variable $host to do proper redirect