Do not kill docker container with SIGKILL #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokku
Outdated
Member
There was a problem hiding this comment.
In practice this does not work consistently. See the open PR for scaling. #1118
Instead I think we want to attempt stop (default timeout is 10 sec) then kill.
Contributor
Author
There was a problem hiding this comment.
@michaelshobbs make sense. So:
docker stop $oldid
sleep $WAIT_FOR_KILL
docker kill $oldidor just
docker stop $oldid
docker kill $oldid
Member
There was a problem hiding this comment.
Just the second one.
From https://docs.docker.com/reference/commandline/cli/#stop
Usage: docker stop [OPTIONS] CONTAINER [CONTAINER...]
Stop a running container by sending SIGTERM and then SIGKILL after a
grace period
-t, --time=10 Seconds to wait for stop before killing it
When we will use `kill` command on `docker` main process will receive `SIGKILL` signal. This will result in immediate termination of processes. We need to send a signal `SIGTERM` to main process and give the opportunity to close application in correct way.
michaelshobbs
added a commit
that referenced
this pull request
Apr 29, 2015
Do not kill docker container with SIGKILL
Member
|
I jumped the gun here and missed the change to |
Contributor
Author
|
@michaelshobbs sure, I will create pull request for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we will use
killcommand ondockermain process will receiveSIGKILLsignal. This will result in immediate termination ofprocesses. We need to send a signal
SIGTERMto main process and givethe opportunity to close application in correct way.