这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@YellowApple
Copy link
Contributor

Piping the output of curl or wget -O- to a shell is a very bad idea for multiple reasons; security concerns aside, doing so provides no opportunity for the script's download to finish before execution starts, so if the download is interrupted for some reason (perhaps because of an intermittent network failure), the incompletely-downloaded script will still run with potentially disastrous results. See here for a more in-depth description.

Piping the output of `curl` or `wget -O-` to a shell is a very bad idea for multiple reasons; security concerns aside, doing so provides no opportunity for the script's download to finish before execution starts, so if the download is interrupted for some reason (perhaps because of an intermittent network failure), the incompletely-downloaded script will still run with potentially disastrous results.  See [here](http://www.seancassidy.me/dont-pipe-to-your-shell.html) for a more in-depth description.
josegonzalez added a commit that referenced this pull request Apr 22, 2015
@josegonzalez josegonzalez merged commit d960b9c into dokku:master Apr 22, 2015
@josegonzalez
Copy link
Member

FWIW, that command would run the following:

Which is what is in our debian installation notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants